Introduce configuration file support#888
Conversation
6dbe73e to
b77dd62
Compare
b77dd62 to
d60d74e
Compare
|
The implementation looks good but I'm not sure about the format we use for |
Co-authored-by: Alex Rocha <alexcrocha@users.noreply.github.com>
Co-authored-by: Alex Rocha <alexcrocha@users.noreply.github.com>
Co-authored-by: Alex Rocha <alexcrocha@users.noreply.github.com>
d60d74e to
6d7fc24
Compare
|
Switched to TOML according to our discussions. |
st0012
left a comment
There was a problem hiding this comment.
In the PR description, we still mention .rubydex and INI format. Let's update it
Also, should we use .rubydex.toml? Is it intentional to drop . prefix with switching to toml?
|
I removed the leading dot intentionally since we now have a file extension. Just |
While Rubydex is a framework that can be used to build all sorts of tools, in most cases we want consistency in the base analysis.
For example, imagine you have an LSP and a linter based on Rubydex, but because they each configure the framework differently, you get different results in the editor vs in the CLI. That would be a pretty poor experience.
I believe we can provide an easy way to ensure consistency while still maintaining flexibility so that the odd case can load custom configuration files for a random tool.
Implementation
I recommend reviewing per commit:
load_configin the Ruby APIrubydex.tomldefault configuration for this repo itself