Patch ConnectionPool to carry semian_resource #575
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working on replacing references to a single global
Redis
connection in one of the Shopify apps with aConnectionPool
-wrappedRedis
to make it thread-safe.I found that so many spots expect to be able to call
semian_resource
on that connection object. And I don't think we should require those to go check out connection from a pool via@redis_pool.with { conn.semian_resource }
to accesssemian_resource
.Instead, we could add
semian_resource
as an accessor onConnectionPool
for convenience.Example of using that with Redis:
cc @byroot @danmayer for review