misc cleanup of dual circuit breaker (Dec 19) #947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an expectation for mark_success to improve classic test coverage Use a setter method style for adaptive_circuit_breaker_selector Use a class instead of a method for the ExperimentFlags in the demo
adriangudas
requested review from
AbdulRahmanAlHamali,
Aguasvivas22 and
anagayan
adriangudas
commented
Dec 20, 2025
| end | ||
|
|
||
| def self.adaptive_circuit_breaker_selector(selector) # rubocop:disable Style/ClassMethodsDefinitions | ||
| def self.adaptive_circuit_breaker_selector=(selector) # rubocop:disable Style/ClassMethodsDefinitions |
Author
There was a problem hiding this comment.
Maybe this doesn't have to change. Or I can at least add the old method side-by-side so there's backwards compatibility.
Author
|
Actually, thinking of removing the code updates here (maybe the experiment / test updates are ok). I'm realizing now that we're better off considering our code frozen since it's in working state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few minor cleanup/fixes:
Note: This PR introduces a stylistic change to make
adaptive_circuit_breaker_selectorto be a setter method, so we'll have to change the way we call it fromSemian::DualCircuitBreaker.adaptive_circuit_breaker_selector(value)to
Semian::DualCircuitBreaker.adaptive_circuit_breaker_selector = value..and make sure that is effectively socialized with our team before merging.