Update build_deploy with allow_concurrency keyword argument
#1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kartiki975
force-pushed
the
update-deploy-api
branch
from
100c8c7 to
e73b267
Compare
kartiki975
force-pushed
the
update-deploy-api
branch
from
e73b267 to
4ce20f5
Compare
kartiki975
force-pushed
the
update-deploy-api
branch
from
4ce20f5 to
5e3767d
Compare
| accepts :require_ci, Boolean, default: false | ||
| accepts :env, Hash, default: {} | ||
| end | ||
| def create | ||
| commit = stack.commits.by_sha(params.sha) || param_error!(:sha, 'Unknown revision') | ||
| param_error!(:force, "Can't deploy a locked stack") if !params.force && stack.locked? | ||
| param_error!(:require_ci, "Commit is not deployable") if params.require_ci && !commit.deployable? | ||
| deploy = stack.trigger_deploy(commit, current_user, env: params.env, force: params.force) | ||
| deploy = stack.trigger_deploy(commit, current_user, env: params.env, force: params.force, |
There was a problem hiding this comment.
We need to add some testing around this - as it stands, I think that if params.allow_concurrency equals false but params.force equals true, allow_concurrency is going to end up evaluated to true due to the || condition
Add unit tests
kartiki975
force-pushed
the
update-deploy-api
branch
from
5e3767d to
c2c77ea
Compare
kwboyd-shopify
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 of 2 PRs (2nd PR will be in an Internal Shopify service)
There is an internal Shopify ticket that hopes to separate concurrent deploys from
force=truefor the deploy API. To avoid overriding the wholebuild_deploymethod in our internal service, I have updated the method signature to acceptallow_concurrencyfield but default it toforceto keep the existing implementation.Changelog and README.md have been updated in case other users would also like to more control of the concurrency of deployments; note, that this differs from rollback whose concurrency is still limited to
force.