Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Update App Proxy Form documentation #1822

Merged
merged 4 commits into from
Jan 20, 2025
Merged

Conversation

lizkenyon
Copy link
Contributor

WHY are these changes introduced?

Fixes #1073

We need to clarify the limitations of Remix URL rewrites

WHAT is this pull request doing?

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have used pnpm changeset to create a draft changelog entry (do NOT update the CHANGELOG.md files manually)
  • I have added/updated tests for this change
  • I have documented new APIs/updated the documentation for modified APIs (for public APIs)

@lizkenyon lizkenyon requested a review from a team as a code owner December 3, 2024 22:01
Clarify limiations with remix url rewriting
@lizkenyon lizkenyon force-pushed the liz/update-app-proxy-form-docs branch from 4269cd1 to 6febc1d Compare December 4, 2024 22:41
@Arkham Arkham enabled auto-merge January 17, 2025 11:31
@Arkham Arkham merged commit 66fd00e into main Jan 20, 2025
7 checks passed
@Arkham Arkham deleted the liz/update-app-proxy-form-docs branch January 20, 2025 16:22
@vanceism7
Copy link

This didn't really fix #1073, but thanks for updating the docs

@lizkenyon
Copy link
Contributor Author

Hey @vanceism7

Thanks for the flag. I have created an internal ticket for a redirect helper for app proxies as described in the comment.
Would that fix your issue, or is there something else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[shopify-app-remix] Form submissions redirects broken in proxied remix app
4 participants