Update token-exchange.ts #691
Open
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add error log for token exchange which will help user to find problem easily.
| @@ -132,6 +132,7 @@ export class TokenExchangeStrategy<Config extends AppConfigArg> | |||
| requestedTokenType, | |||
| }); | |||
| } catch (error) { | |||
| logger.error('token exchange error', error) | |||
There was a problem hiding this comment.
Suggested change
| logger.error('token exchange error', error) | |
| logger.error('Token exchange error', error) |
For consistency
|
Thank you for the PR @damonchen, I've added a very small comment because all the other errors in the codebase are capitalized, but looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add error log for token exchange which will help user to find problem easily.
WHY are these changes introduced?
Help to fixed the problem: Shopify/shopify-app-template-remix#561
WHAT is this pull request doing?
add error log for token exchange which will help user to find problem easily.
Type of change
Checklist