-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build script to use remix vite:build
and update Readme with Vercel hosting instructions for Remix with Vite
#687
Conversation
Hi there @jeffsee55 👋 Thank you for this! If we can eliminate special cases for deployment that is great! I was wondering if you happened to test deploying one of our app templates? |
Thanks @lizkenyon, I did get this to deploy successfully with an existing template, I'm not sure exactly what you mean by one of your app templates. I don't think this relates to the Vercel deploys which are failing, but I did want to highlight again that the |
Hi @jeffsee55 Sorry by one of our templates, I was referring to the code in this repository. Yes, we should be good to change the build script to what you have. If you are able to sign the CLA, we will test this on our side and get this merged! Thanks again! |
Thanks @lizkenyon, signed! I also resolved a merge conflict that was created from #358. I think the area that was updated in that PR was a typo (extra space) so went ahead and continued to delete that sentence |
Hey @jeffsee55 This is slightly unrelated, but it seems new deploys of Shopify App Remix templates are now failing. We tracked this down to our use ofimport assertions in one of our libraries. I created a discussion on the Vercel github, and I was wondering if you could help getting some eyes on this by the right person? |
Thanks @lizkenyon, we'll take a look! |
Thanks again for your contribution here! |
Update build script to use `remix vite:build` and update Readme with Vercel hosting instructions for Remix with Vite
Vercel recently shipped a Remix Vite plugin that no longer requires a forked version of Remix. The package also exports platform-specific utilities that may need to be imported at runtime, detailed in the docs link above. This PR updates the README for the Vercel-specific instructions.
It also modifies the build script, I noticed that the build command was reverted from
remix vite:build
here, I'm not sure on the specifics of why that was necessary but the Vercel preset won't work without theremix vite:build
command as far as I know. If there's a reason theremix
command can't be used then this PR should just be closed as it won't help.Checklist
Note: once this PR is merged, it becomes a new release for this template.
I have added/updated tests for this changeREADME.md
file and other related documentation, if applicable