Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude node 22 #698

Merged
merged 1 commit into from
May 3, 2024
Merged

Exclude node 22 #698

merged 1 commit into from
May 3, 2024

Conversation

lizkenyon
Copy link
Contributor

@lizkenyon lizkenyon commented May 3, 2024

WHY are these changes introduced?

Test this PR

npm init @shopify/app@latest -- --template=https://github.com/Shopify/shopify-app-template-remix.git#<your-branch-name>
image image
exclude-node-22.mp4

Checklist

Note: once this PR is merged, it becomes a new release for this template.

  • I have added/updated tests for this change
  • I have made changes to the README.md file and other related documentation, if applicable

Node 22 removes import assertions, which breaks the app
@lizkenyon lizkenyon requested a review from a team as a code owner May 3, 2024 21:15
@lizkenyon lizkenyon merged commit 17e40d4 into main May 3, 2024
5 checks passed
lizkenyon added a commit that referenced this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants