Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable single fetch #899

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Disable single fetch #899

merged 3 commits into from
Dec 5, 2024

Conversation

lizkenyon
Copy link
Contributor

WHY are these changes introduced?

  • Disable the singleFetch future flag while we determine the limitations with redirects.

WHAT is this pull request doing?

Test this PR

shopify app init --template=https://github.com/Shopify/shopify-app-template-remix#<your-branch-name>

Checklist

  • I have made changes to the README.md file and other related documentation, if applicable
  • I have added an entry to CHANGELOG.md
  • I'm aware I need to create a new release when this PR is merged

@lizkenyon lizkenyon requested a review from a team as a code owner December 5, 2024 19:46
@lizkenyon lizkenyon merged commit bca9802 into main Dec 5, 2024
5 checks passed
@lizkenyon lizkenyon deleted the liz/disable-single-fetch branch December 5, 2024 20:43
github-actions bot pushed a commit that referenced this pull request Dec 5, 2024
@silintzir
Copy link

In my case #897, that the billing api failed to redirect, the v3_singleFetch was blocking the x-shopify-api-request-failure-reauthorize-url header from being set with the Response returned from the billing api call. Manually adding the headers function to the route and returning all headers fixed the issue.

@lizkenyon
Copy link
Contributor Author

Thank @silintzir! I am seeing that as well.

@davidhousedev
Copy link

@lizkenyon is there an issue we can track so we know when single fetch can be safely enabled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants