Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump vite from 5.4.11 to 6.0.7" #938

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

gonzaloriestra
Copy link
Contributor

@gonzaloriestra gonzaloriestra commented Jan 23, 2025

Reverts #931

The app creation from the CLI is broken for TS: shopify app init --template remix --flavor typescript:

Error coming from `npm install`

Command failed with exit code 1: npm install
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: @remix-run/[email protected]
npm error Found: [email protected]
npm error node_modules/vite
npm error   dev vite@"^6.0.7" from the root project
npm error   peerOptional vite@"*" from [email protected]
npm error   node_modules/vite-tsconfig-paths
npm error     vite-tsconfig-paths@"^5.0.1" from the root project
npm error
npm error Could not resolve dependency:
npm error peerOptional vite@"^5.1.0" from @remix-run/[email protected]
npm error node_modules/@remix-run/dev
npm error   @remix-run/dev@"^2.7.1" from the root project
npm error   peer @remix-run/dev@"^2.15.2" from @remix-run/[email protected]
npm error   node_modules/@remix-run/fs-routes
npm error     @remix-run/fs-routes@"^2.15.0" from the root project
npm error   1 more (@remix-run/route-config)
npm error
npm error Conflicting peer dependency: [email protected]
npm error node_modules/vite
npm error   peerOptional vite@"^5.1.0" from @remix-run/[email protected]
npm error   node_modules/@remix-run/dev
npm error     @remix-run/dev@"^2.7.1" from the root project
npm error     peer @remix-run/dev@"^2.15.2" from @remix-run/[email protected]
npm error     node_modules/@remix-run/fs-routes
npm error       @remix-run/fs-routes@"^2.15.0" from the root project
npm error     1 more (@remix-run/route-config)
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /Users/gonzalo/.npm/_logs/2025-01-23T10_27_51_798Z-eresolve-report.txt

npm error A complete log of this run can be found in: /Users/gonzalo/.npm/_logs/2025-01-23T10_27_51_798Z-debug-0.log

It works with this branch:
shopify app init --template https://github.com/Shopify/shopify-app-template-remix#revert-931-dependabot/npm_and_yarn/vite-6.0.7

@gonzaloriestra gonzaloriestra marked this pull request as ready for review January 23, 2025 10:36
@gonzaloriestra gonzaloriestra requested a review from a team as a code owner January 23, 2025 10:36
Copy link
Contributor

@Arkham Arkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops thanks!

@Arkham Arkham merged commit 0861fd7 into main Jan 23, 2025
5 checks passed
@Arkham Arkham deleted the revert-931-dependabot/npm_and_yarn/vite-6.0.7 branch January 23, 2025 10:55
github-actions bot pushed a commit that referenced this pull request Jan 23, 2025
…rn/vite-6.0.7

Revert "Bump vite from 5.4.11 to 6.0.7"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants