Handle invalid token when adding redirection headers #1945
+26
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Currently, while decoding a token while redirecting to login, it's possible for errors to occur. Example error:
Signature has expired
.This PR rescues token decoding errors and handles them gracefully. The login url will not include the shop param in this scenario.
Exception:
Reviewer's guide to testing
The test covers this scenario by simulating an error decoding the session token, in this case the error is
Not enough or too many segments
but it covers any error while decoding tokens.Things to focus on
I'm unfamiliar with this repo so please ensure the way that the exception is handled won't cause issues in the redirect.
Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.md
if the changes would impact usersREADME.md
, if appropriate./docs
, if necessary