Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add audience to translation.yml #1956

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Add audience to translation.yml #1956

merged 1 commit into from
Mar 19, 2025

Conversation

mattellig
Copy link
Member

Part of https://github.com/Shopify/translation-platform/issues/1638

Adding the audience config to any components where it's not set, so that Translation Platform can remove this repository from a list of internal hardcoded audience values.

@mattellig mattellig requested a review from Al-Campuzano March 19, 2025 13:49
@mattellig mattellig self-assigned this Mar 19, 2025
@mattellig mattellig requested a review from a team as a code owner March 19, 2025 13:49
@translation-platform
Copy link
Contributor

This PR changes one or more translation configuration files, or at least they look like translation configuration files. Please make sure you know what you're doing!

  • Read the docs on this config file here.
  • If you have any questions or need a hand, reach out to us on Slack at #help-localization.
  • If this change involves moving a large number of files, please do not merge it without consulting us.

Files added or modified:

  • translation.yml

Pinging @Shopify/translation-tooling for awareness.

Copy link
Contributor

@lizkenyon lizkenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY

@mattellig mattellig merged commit 49e2fb5 into main Mar 19, 2025
8 checks passed
@mattellig mattellig deleted the mattellig/audience branch March 19, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants