WIP: Prism work, merge only #403
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting all the test output was not particularly useful and created a lot of noise.
Translate rescue modifier nodes
Pass `--test_output=errors` flag to CI
Add a new script to verify that our prism regression parse trees are up to date, and run that script in CI to make sure that we are updating our parsing output as Sorbet master changes.
Verify test expectations in CI
Move pattern-matching code into a new set of functions
Implement Prism -> Sorbet translation for alternation patterns (`a | b`)
Implement Prism -> Sorbet translation for variable binding in patterns
Implement Prism -> Sorbet translation for pinning patterns
Co-authored-by: Alexander Momchilov <[email protected]>
Translate rescue node
Implement Prism -> Sorbet translation for shareable constants
Add `local_vars` tests to prism corpus and exclude failing test
Generate empty Args node for method definitions with empty parentheses
Fix failing local_vars test by translating post params!
Handle post `while`/`until` modifiers
And exclude failing tests
Add namer tests to Prism corpus
Modify locations of kw arguments and params to match legacy parser
In cases like `foo.()`, the message would be `:call`, but the message location would have null start and end. In this case, we need to fall back to use the call operator location.
Correctly translate no-message calls' message locations
This is not covered in parse tree location tests, but reflected in symbol table tests: when we write `FOO = 1` (or other constant write nodes), the location of `FOO` should just be the name, not the entire assignment. In those cases, we should use `name_loc` instead of `base.location`.
Correctly translate constant write nodes' location
When the symbol is used as `a: 1`, the location should not include the colon.
Fix symbol location for hash, keyword argument keys
The main blocker for upstreaming Prism parser to Sorbet is that we currently rely on Ruby to build Prism, as its required by Prism's `rake template` task. But by package the files generated by `rake template` in Prim's release, we will be able to remove the dependency on Ruby while significantly simplify the build configurations for Prism.
…-release Use improved libprism source to build Prism without dependency on Ruby
When ENFORCE macros fail, they use fmt (via spdlog) to format error messages. Add a formatter specialization for pm_node_type to properly display Prism node types in these error messages. Instead of showing numeric values, the formatter uses pm_node_type_to_str to display human-readable node type names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test for upstreaming our Prism work. In this PR, I've left all our commits as-is and just merged Prism master
Motivation
Test plan
See included automated tests.