Check dynamic const multi-assignment #817
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the dynamic assignment check for multi targets. The comments in the regression test said
Sorbet doesn't do the dynamic constant workaround for multi-target assignments—that may have been the case when the original translator was added, but doesn't appear to be so now.The following code was crashing:
Enabling the dynamic assignment check for the multi target results in this being desugared in the same way as the original parser, and therefore no longer crashes:
Prism:
Original:
The error messages are also identical: