Use constant name missing for invalid constant path #821
+30
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amomchilov
force-pushed
the
desugar-remaining
branch
2 times, most recently
from
d96acf3 to
7f35d5d
Compare
The behavior is different from the original parser which just throws the module away.
thomasmarshall
force-pushed
the
handle-constant-paths-missing-names
branch
from
08a0d3c to
5264546
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously fixed something similar here, but apparently that wasn't enough. For example:
Prism parses the
ConstantPathNodeas not having a name. The code will crash when the unresolved constant name iscore::Names::empty(). This Pr fixes that by usingcore::Names::Constants::ConstantNameMissing()instead (which is arguably more appropriate anyway).The desugar tree is different to the original parser, which throws away more of the tree. The easier fix for the Prism parse tree is to insert this
ConstantNameMissingconstant and retain the rest of the tree.