Fix missing constant name in assignment #824
Open
+37
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amomchilov
force-pushed
the
desugar-remaining
branch
2 times, most recently
from
d96acf3 to
7f35d5d
Compare
thomasmarshall
force-pushed
the
fix-assignment-unset-constant
branch
from
358b0c4 to
2a30fa0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash when a constant assignment has a missing name:
In this case Prism will parse this as a constant assignment where the constant path node is missing a name.
It seems like this "missing name" issue crops up in a bunch of different places—I'm wondering if there is a more generalizable solution that will catch all cases?