Fix invalid index in for
#825
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amomchilov
force-pushed
the
desugar-remaining
branch
2 times, most recently
from
d96acf3 to
7f35d5d
Compare
thomasmarshall
force-pushed
the
for-invalid-index
branch
from
1195753 to
e0ee88c
Compare
amomchilov
approved these changes
Jan 7, 2026
| }; | ||
|
|
||
| // Index might be invalid in error recovery cases, match original parser behavior. | ||
| if (!isValidTarget(forNode->index)) { |
There was a problem hiding this comment.
You can invert the true/false and not need the negation
Suggested change
| if (!isValidTarget(forNode->index)) { | |
| if (isInvalidTarget(forNode->index)) { |
There was a problem hiding this comment.
I guess you could also just use the switch directly, and either return MK::Nil(location.copyWithZeroLength()); or break
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash with the following:
Prism parses this as a
ForNodewhere theindexfield is aDefNode. That's obviously invalid. The original parser returns aNilfor this cases (and probably others like it). I copied that behavior, checking if the node in theindexfield is a valid node type or not.