Gut out remaining PrismDesugar.cc logic
#829
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jesse Johnson <[email protected]>
Co-authored-by: Thomas Marshall <[email protected]>
Co-authored-by: Jesse Johnson <[email protected]>
Co-authored-by: Jesse Johnson <[email protected]>
Co-authored-by: Jesse Johnson <[email protected]>
Co-authored-by: Jesse Johnson <[email protected]>
Co-authored-by: Jesse Johnson <[email protected]>
Co-authored-by: Jesse Johnson <[email protected]>
Co-authored-by: Thomas Marshall <[email protected]>
Co-authored-by: Alexander Momchilov <[email protected]> Co-authored-by: Thomas Marshall <[email protected]>
Co-authored-by: Alexander Momchilov <[email protected]>
PM_ALIAS_METHOD_NODE return expr_only
…OLATED_STRING_NODE, PM_INTERPOLATED_REGULAR_EXPRESSION_NODE return expr_only
… helper PM_BREAK_NODE, PM_NEXT_NODE, PM_RETURN_NODE are refactored to called to desugarBreakNextReturn and return expr_only Co-authored-by: Thomas Marshall <[email protected]> Co-authored-by: Jesse Johnson <[email protected]>
Delete `parser::NodeWithExpr`
Replace: `auto (.+) = (.+);\n?\n +return expr_only\(move\(\1\)(,.*)?\);` With: `return $2;`
This was referenced Dec 19, 2025
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
amomchilov
changed the title
node2TreeImplBody()PrismDesugar.cc logic
amomchilov
commented
Dec 19, 2025
| if (programNode->statements->body.size == 1) { | ||
| auto statement = desugar(programNode->statements->body.nodes[0]); | ||
|
|
||
| // If the one statement desugars into an instruction sequence of multiple statements, |
Author
There was a problem hiding this comment.
Interesting behaviour: Sorbet.run
Looks intentional?
sorbet@b78c32a#diff-d007a9992fbeb69b231e49e539a717ff3e3bb3d9961b569fd1d83d0034ba9211
jesse-shopify
force-pushed
the
rm-legacy-parser
branch
from
aaea70d to
100555a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Test plan
See included automated tests.