Skip to content

Add support for override(allow_incompatible: :visibility) #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Morriar merged 2 commits into from
Oct 14, 2025
Merged

Add support for override(allow_incompatible: :visibility) #804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
526bb6a
Bump rbi to v0.3.7
Morriar Oct 10, 2025
d4170fc
Add support for `override(allow_incompatible: :visibility)`
Morriar Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ GEM
racc (1.8.1)
rainbow (3.1.1)
rake (13.3.0)
rbi (0.3.6)
rbi (0.3.7)
prism (~> 1.0)
rbs (>= 3.4.4)
rbs (4.0.0.dev.4)
Expand Down
1 change: 1 addition & 0 deletions lib/spoom/rbs.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ def method_annotations
"@final",
"@override",
"@override(allow_incompatible: true)",
"@override(allow_incompatible: :visibility)",
"@overridable",
"@without_runtime"
true
Expand Down
3 changes: 3 additions & 0 deletions lib/spoom/sorbet/translate/rbs_comments_to_sorbet_sigs.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,9 @@ def apply_member_annotations(annotations, sig)
when "@override(allow_incompatible: true)"
sig.is_override = true
sig.allow_incompatible_override = true
when "@override(allow_incompatible: :visibility)"
sig.is_override = true
sig.allow_incompatible_override_visibility = true
when "@overridable"
sig.is_overridable = true
when "@without_runtime"
Expand Down
2 changes: 2 additions & 0 deletions lib/spoom/sorbet/translate/sorbet_sigs_to_rbs_comments.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,8 @@ def apply_member_annotations(sigs)
if sigs.any? { |_, sig| sig.is_override }
@rewriter << if sigs.any? { |_, sig| sig.allow_incompatible_override }
Source::Insert.new(insert_pos, "# @override(allow_incompatible: true)\n#{indent}")
elsif sigs.any? { |_, sig| sig.allow_incompatible_override_visibility }
Source::Insert.new(insert_pos, "# @override(allow_incompatible: :visibility)\n#{indent}")
else
Source::Insert.new(insert_pos, "# @override\n#{indent}")
end
Expand Down
Loading