Merge pull request #1453 from Shopify/fix-active-record-scope-compile…

…r-duplicate-methods

Fix ActiveRecordScope Compiler to not duplicate relation methods of superclass

lib/tapioca/dsl/compilers/active_record_scope.rb

@@ -105,7 +105,7 @@ def scope_method_names
             constant = T.cast(superclass, T.class_of(ActiveRecord::Base))
           end
 
-          scope_methods
+          scope_methods.uniq
         end
 
         sig do

spec/tapioca/dsl/compilers/active_record_scope_spec.rb

@@ -200,6 +200,48 @@ def post_scope(*args, &blk); end
 
                 assert_equal(expected, rbi_for(:Post))
               end
+
+              it "does not duplicate relation includes from abstract parent models" do
+                add_ruby_file("post.rb", <<~RUBY)
+                  class ApplicationRecord < ActiveRecord::Base
+                    self.abstract_class = true
+
+                    default_scope { max_execution_time(100) }
+                  end
+
+                  class ConfigurationRecord < ApplicationRecord
+                    self.abstract_class = true
+
+                    scope :post_scope, -> { where.not(kind: 'private') }
+
+                    default_scope { max_execution_time(200) }
+                  end
+
+                  class Post < ConfigurationRecord
+                    scope :post_scope, -> { where.not(kind: 'private') }
+                  end
+                RUBY
+
+                expected = <<~RBI
+                  # typed: strong
+
+                  class Post
+                    extend GeneratedRelationMethods
+
+                    module GeneratedAssociationRelationMethods
+                      sig { params(args: T.untyped, blk: T.untyped).returns(PrivateAssociationRelation) }
+                      def post_scope(*args, &blk); end
+                    end
+
+                    module GeneratedRelationMethods
+                      sig { params(args: T.untyped, blk: T.untyped).returns(PrivateRelation) }
+                      def post_scope(*args, &blk); end
+                    end
+                  end
+                RBI
+
+                assert_equal(expected, rbi_for(:Post))
+              end
             end
 
             describe "without relations enabled" do