[WIP] [Tapioca Addon] Optimized gem RBI generation Exploration #2121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To support gem RBI generation, we needed a way to detect changes in Gemfile.lock. Currently, changes to this file cause the Ruby LSP to restart, resulting in loss of access to any previous state information. By running git diff on Gemfile.lock, we can detect changes to the file, and trigger the gem RBI generation process. Then we can parse the diff output to determine which gems have been removed, added or modified, and either remove the corresponding RBI files or trigger the RBI generation process for the gems.
Co-authored-by: Kaan Ozkan <[email protected]>
alexcrocha
force-pushed
the
ar/gem-regeneration-git-status
branch
3 times, most recently
from
b28ebb0 to
3ab954c
Compare
alexcrocha
force-pushed
the
ar/gem-regeneration-git-status
branch
13 times, most recently
from
290c482 to
2db5af3
Compare
alexcrocha
force-pushed
the
ar/gem-regeneration-git-status
branch
2 times, most recently
from
006b822 to
1b000ac
Compare
alexcrocha
force-pushed
the
ar/gem-regeneration-git-status
branch
7 times, most recently
from
9d4fd2a to
66e6154
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP Exploration
Motivation
Soon™
Implementation
Tests