Update active record relations DSL count to accept a block argument #2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaanOzkan
reviewed
Jan 16, 2025
| @@ -402,6 +402,7 @@ def create_group_chain_methods(klass) | |||
| "count", | |||
| parameters: [ | |||
| create_opt_param("column_name", type: "T.untyped", default: "nil"), | |||
| create_block_param("block", type: "T.nilable(T.proc.params(record: T.untyped).returns(T.untyped))"), | |||
There was a problem hiding this comment.
I don't know why groupchain count is different than regular count definition. I think it'll be good to take a closer look and be consistent if appropriate. Regular one uses overloaded sigs instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While working on a Rails application, I have code that is of the format
Model.count {|m| m.foo_relation.boolean?}.I don't want to write this as
.select{}.countas that would violate the Rubocop::Cop::Performance::CopThe fix is to update the type signatures DSL for active record relations to allow
countto accept an optional block argument.see https://edgeapi.rubyonrails.org/classes/ActiveRecord/Calculations.html#method-i-count
Implementation
Added to a
create_block_paramcall for active record relationscountmethod,lib/tapioca/dsl/compilers/active_record_relations.rbTests
Updated existing tests for active record relations
countmethod to accept an optional block parameter.