Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate all T.let to RBS inline comments supported by Sorbet #2240

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Morriar
Copy link
Collaborator

@Morriar Morriar commented Mar 19, 2025

Using spoom srb assertions translate all assertions like:

x = T.let(foo, String)

can be translated to:

x = foo #: String

and understood by Sorbet with the option --enable-experimental-rbs-assertions.

Morriar added 8 commits March 19, 2025 18:17
Signed-off-by: Alexandre Terrasa <[email protected]>
Using `spoom srb assertions translate`.

Signed-off-by: Alexandre Terrasa <[email protected]>
We want the Rubocop comment after the RBS one.

Signed-off-by: Alexandre Terrasa <[email protected]>
Signed-off-by: Alexandre Terrasa <[email protected]>
Signed-off-by: Alexandre Terrasa <[email protected]>
Signed-off-by: Alexandre Terrasa <[email protected]>
@Morriar Morriar added the chore label Mar 19, 2025
@Morriar Morriar self-assigned this Mar 19, 2025
@Morriar Morriar requested a review from a team as a code owner March 19, 2025 22:34
Copy link
Member

@paracycle paracycle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants