Make ActiveRecord delete/destroy_by argument a rest parameters - #2497
Merged
Conversation
Member
|
I can't see the tests changes. Did you forget to push? |
Contributor
Author
|
@rafaelfranca Ha! Yeah, it's there now. |
paracycle
approved these changes
Jan 21, 2026
paracycle
enabled auto-merge
January 21, 2026 23:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
delete_byanddestroy_byActiveRecord methods take multiple arguments (likewhere) instead of a single argument.Implementation
I just replaced
create_paramwithcreate_rest_paramand updated the testsTests
I updated the tests to expect the rest argument instead of a single argument