Skip to content
CI

Update grammar to parse inside style tags #1641

Sign in to view logs

Update grammar to parse inside style tags

Update grammar to parse inside style tags #1641

Triggered via push January 6, 2025 15:10
@aswamyaswamy
pushed 3363584
bugfix/variable-not-used-false-positive
Status Failure
Total duration 2m 2s
Artifacts –

ci.yml

on: push
Code quality
1m 53s
Code quality
Matrix: tests
Fit to window
Zoom out
Zoom in

Annotations

17 errors and 2 warnings
packages/liquid-html-parser/src/grammar.spec.ts > Unit: liquidHtmlGrammar > Case: common to all grammars > should parse or not parse HTML+Liquid: packages/liquid-html-parser/src/grammar.spec.ts#L42
AssertionError: {% style %}{% endstyle %}: expected false to be true - Expected + Received - true + false ❯ packages/liquid-html-parser/src/grammar.spec.ts:42:62 ❯ packages/liquid-html-parser/src/grammar.spec.ts:13:16
packages/liquid-html-parser/src/stage-1-cst.spec.ts > Unit: Stage 1 (CST) > Unit: toLiquidHtmlCST(text) and toLiquidCST(text) > Case: LiquidNode > should parse raw tags: packages/liquid-html-parser/src/stage-1-cst.spec.ts#L874
AssertionError: toLiquidHtmlCST(text): expected 'LiquidTagOpen' to equal 'LiquidRawTag' Expected: "LiquidRawTag" Received: "LiquidTagOpen" ❯ packages/liquid-html-parser/src/stage-1-cst.spec.ts:874:42 ❯ packages/liquid-html-parser/src/stage-1-cst.spec.ts:871:26
packages/liquid-html-parser/src/stage-1-cst.spec.ts > Unit: Stage 1 (CST) > Unit: toLiquidHtmlCST(text) and toLiquidCST(text) > Case: LiquidNode > should parse raw tag children: packages/liquid-html-parser/src/stage-1-cst.spec.ts#L896
AssertionError: toLiquidHtmlCST(text): expected 'LiquidTagOpen' to equal 'LiquidRawTag' Expected: "LiquidRawTag" Received: "LiquidTagOpen" ❯ packages/liquid-html-parser/src/stage-1-cst.spec.ts:896:42 ❯ packages/liquid-html-parser/src/stage-1-cst.spec.ts:885:33
packages/liquid-html-parser/src/stage-2-ast.spec.ts > Unit: Stage 2 (AST) > Unit: toLiquidHtmlAST(text) and toLiquidAST(text) > should parse raw-like tags: packages/liquid-html-parser/src/stage-2-ast.spec.ts#L789
AssertionError: toLiquidHtmlAST(text): expected 'LiquidTag' to deeply equal 'LiquidRawTag' Expected: "LiquidRawTag" Received: "LiquidTag" ❯ packages/liquid-html-parser/src/stage-2-ast.spec.ts:789:49
packages/theme-check-common/src/checks/liquid-html-syntax-error/index.spec.ts > Module: LiquidHTMLSyntaxError > should report unexpected tokens (3): packages/theme-check-common/src/checks/liquid-html-syntax-error/index.spec.ts#L88
AssertionError: expected 'SyntaxError: expected "#", a letter, …' to equal 'SyntaxError: expected "#", a letter, …' Expected: "SyntaxError: expected "#", a letter, "when", "sections", "section", "render", "liquid", "layout", "increment", "include", "elsif", "else", "echo", "decrement", "content_for", "cycle", "continue", "break", "assign", "tablerow", "unless", "if", "ifchanged", "for", "case", "capture", "paginate", "form", "end", "style", "stylesheet", "schema", "javascript", "raw", "comment", or "doc"" Received: "SyntaxError: expected "#", a letter, "when", "sections", "section", "render", "liquid", "layout", "increment", "include", "elsif", "else", "echo", "decrement", "content_for", "cycle", "continue", "break", "assign", "tablerow", "unless", "if", "ifchanged", "for", "case", "capture", "paginate", "style", "form", "end", "stylesheet", "schema", "javascript", "raw", "comment", or "doc"" ❯ packages/theme-check-common/src/checks/liquid-html-syntax-error/index.spec.ts:88:36
Tests / OS ubuntu-latest / NodeJS 20
Process completed with exit code 1.
Tests / OS windows-latest / NodeJS 20
The job was canceled because "ubuntu-latest_20" failed.
Tests / OS windows-latest / NodeJS 20
The operation was canceled.
Tests / OS windows-latest / NodeJS 18
The job was canceled because "ubuntu-latest_20" failed.
Tests / OS windows-latest / NodeJS 18
The operation was canceled.
Tests / OS ubuntu-latest / NodeJS 18
The job was canceled because "ubuntu-latest_20" failed.
packages/liquid-html-parser/src/grammar.spec.ts > Unit: liquidHtmlGrammar > Case: common to all grammars > should parse or not parse HTML+Liquid: packages/liquid-html-parser/src/grammar.spec.ts#L42
AssertionError: {% style %}{% endstyle %}: expected false to be true - Expected + Received - true + false ❯ packages/liquid-html-parser/src/grammar.spec.ts:42:62 ❯ packages/liquid-html-parser/src/grammar.spec.ts:13:16
packages/liquid-html-parser/src/stage-1-cst.spec.ts > Unit: Stage 1 (CST) > Unit: toLiquidHtmlCST(text) and toLiquidCST(text) > Case: LiquidNode > should parse raw tags: packages/liquid-html-parser/src/stage-1-cst.spec.ts#L874
AssertionError: toLiquidHtmlCST(text): expected 'LiquidTagOpen' to equal 'LiquidRawTag' Expected: "LiquidRawTag" Received: "LiquidTagOpen" ❯ packages/liquid-html-parser/src/stage-1-cst.spec.ts:874:42 ❯ packages/liquid-html-parser/src/stage-1-cst.spec.ts:871:26
packages/liquid-html-parser/src/stage-1-cst.spec.ts > Unit: Stage 1 (CST) > Unit: toLiquidHtmlCST(text) and toLiquidCST(text) > Case: LiquidNode > should parse raw tag children: packages/liquid-html-parser/src/stage-1-cst.spec.ts#L896
AssertionError: toLiquidHtmlCST(text): expected 'LiquidTagOpen' to equal 'LiquidRawTag' Expected: "LiquidRawTag" Received: "LiquidTagOpen" ❯ packages/liquid-html-parser/src/stage-1-cst.spec.ts:896:42 ❯ packages/liquid-html-parser/src/stage-1-cst.spec.ts:885:33
packages/liquid-html-parser/src/stage-2-ast.spec.ts > Unit: Stage 2 (AST) > Unit: toLiquidHtmlAST(text) and toLiquidAST(text) > should parse raw-like tags: packages/liquid-html-parser/src/stage-2-ast.spec.ts#L789
AssertionError: toLiquidHtmlAST(text): expected 'LiquidTag' to deeply equal 'LiquidRawTag' Expected: "LiquidRawTag" Received: "LiquidTag" ❯ packages/liquid-html-parser/src/stage-2-ast.spec.ts:789:49
packages/theme-check-common/src/checks/liquid-html-syntax-error/index.spec.ts > Module: LiquidHTMLSyntaxError > should report unexpected tokens (3): packages/theme-check-common/src/checks/liquid-html-syntax-error/index.spec.ts#L88
AssertionError: expected 'SyntaxError: expected "#", a letter, …' to equal 'SyntaxError: expected "#", a letter, …' Expected: "SyntaxError: expected "#", a letter, "when", "sections", "section", "render", "liquid", "layout", "increment", "include", "elsif", "else", "echo", "decrement", "content_for", "cycle", "continue", "break", "assign", "tablerow", "unless", "if", "ifchanged", "for", "case", "capture", "paginate", "form", "end", "style", "stylesheet", "schema", "javascript", "raw", "comment", or "doc"" Received: "SyntaxError: expected "#", a letter, "when", "sections", "section", "render", "liquid", "layout", "increment", "include", "elsif", "else", "echo", "decrement", "content_for", "cycle", "continue", "break", "assign", "tablerow", "unless", "if", "ifchanged", "for", "case", "capture", "paginate", "style", "form", "end", "stylesheet", "schema", "javascript", "raw", "comment", or "doc"" ❯ packages/theme-check-common/src/checks/liquid-html-syntax-error/index.spec.ts:88:36
Tests / OS ubuntu-latest / NodeJS 18
The operation was canceled.
Tests / OS ubuntu-latest / NodeJS 20
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Code quality
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636