Fix bug where theme check would fail for theme app extensions #861
+43
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug only surfaces when a developer would manually run the theme check against a theme app extension from the CLI. Inside the VSCode extension we were already doing the right thing so you wouldn't notice it there and the Shopify CLI hardcodes the check when you build your app so you wouldn't notice it there either. This adds some logic to where we load the config to check if we're inside of an app by looking for two app-like config files. If so, we use `theme-check:theme-app-extension` as our default checks rather than the recommended. This ensures that our context is appropriately set as 'app' instead of 'theme' and removes false positives when running the check.
jamesmengo
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
This bug only surfaces when a developer would manually run the theme check against a theme app extension from the CLI. Inside the VSCode extension we were already doing the right thing so you wouldn't notice it there and the Shopify CLI hardcodes the check when you build your app so you wouldn't notice it there either.
This adds some logic to where we load the config to check if we're inside of an app by looking for two app-like config files. If so, we use
theme-check:theme-app-extensionas our default checks rather than the recommended. This ensures that our context is appropriately set as 'app' instead of 'theme' and removes false positives when running the check.