Added support for setting seed for deterministic results.#610
Open
tboloo wants to merge 2 commits intoShopify:mainfrom
Open
Added support for setting seed for deterministic results.#610tboloo wants to merge 2 commits intoShopify:mainfrom
tboloo wants to merge 2 commits intoShopify:mainfrom
Conversation
As of Go 1.20 the math/rand package has been updated to use a stable random number generator by default, also there is no longer a global random number generator (`rand.Seed(seed int64)`), which would be used by all code in application. This change restores the previous behavior by passing around the seed to all functions that require random numbers.
Toxiproxy can be run with --seed <seed> parameter to make the runs deterministic.
Author
|
I have signed the CLA! |
|
+1 this would be a great feature to have when using toxiproxy for measuring improvements over time by reducing the randomness. Is there any way to revive this effort? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of Go 1.20 the math/rand package has been updated to use a stable random number generator by default, also there is no longer a global random number generator (
rand.Seed(seed int64)), which would be used by all code in application.This change restores the previous behavior by passing around the seed to all functions that require random numbers.