Bugfix: don't stop proxies when using hostnames to specify listen addresses #631
+118
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinbrandt
force-pushed
the
fix-hostnames-reset-proxies
branch
from
f9d1f64 to
518377c
Compare
…resses Before this change we'd stop existing proxies when populating a set of proxies when the listen addresses were specified using hostnames instead of IP addresses. This is very surprising as we encourage users to populate proxies at the begin of an application start: > A /populate call can be included for example at application start to ensure > all required proxies exist. It is safe to make this call several times, since > proxies will be untouched as long as their fields are consistent with the new > data. This is (currently) only partially true as it doesn't work when using hostnames. For upstream services this isn't a problem because we never store the resolved address. The change introduces a "Differs" function on a proxy to determine if two proxies are different in terms of listening address and upstream service. This is now used both when changing collections as well as updating individual proxies. Closes #131.
robinbrandt
force-pushed
the
fix-hostnames-reset-proxies
branch
from
518377c to
5ca36b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change we'd stop existing proxies when populating a set of proxies when the listen addresses were specified using hostnames instead of IP addresses.
This is very surprising as we encourage users to populate proxies at the begin of an application start:
This is (currently) only partially true as it doesn't work when using hostnames.
For upstream services this isn't a problem because we never store the resolved address.
The change introduces a "Differs" function on a proxy to determine if two proxies are different in terms of listening address and upstream service. This is now used both when changing collections as well as updating individual proxies.
Closes #131.