[Ui components]: Component dts files #2801
Conversation
Add version string into registration call
Add remote-dom components for Admin
Remove the generator.js script since it's been moved to a different repo
Update Admin components
Add stable Admin components
…tions Add definitions for TextArea and TextField
Add Box and update to use `s-` prefix
Update definitions for `[email protected]`
Adding Table props
[Admin UI Components] Add Clickable and Checkbox component
…xamples-for-standard-API-v2 customer account doc -- updatecexamples for standard API
…ll-js-version-doc customer account doc - delete all js version doc
…tests-to-unblock-ci Customer account - delete hook tests to unblock lint
| } | ||
| export interface AbbreviationElement extends AbbreviationProps, Omit<HTMLElement, 'id' | 'title'> { | ||
| } | ||
| declare global { |
There was a problem hiding this comment.
Just noticed that you're missing the preact jsx types. Also, we discovered that preact overwrites conflicting handler props that you have to omit (see related PR for Admin). Doing something like this should work
declare module 'preact' {
namespace createElement.JSX {
interface IntrinsicElements {
's-abbreviation': Omit<
HTMLAttributes<HTMLElement>,
Extract<keyof HTMLAttributes<HTMLElement>, `on${Capitalize<string>}`>
> &
AbbreviationProps;
}
}
}There was a problem hiding this comment.
Oh... noice, will add this in the checkout-web side then, thanks trish :D
There was a problem hiding this comment.
I tophatted this, but the component types still aren't working and that is because of what Trish mentioned above ☝️ relating to the preact jsx types.
There was a problem hiding this comment.
ok, I'll work on he checkout-web side to make the additions.
How about the JS ones ?? does that work fine ? or same ?
oliverigor
changed the title
|
/snapit |
|
🫰✨ Thanks @jamesvidler! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/ui-extensions": "0.0.0-snapshot-20250424141200" |
|
/snapit |
|
🫰✨ Thanks @oliverigor! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/ui-extensions": "0.0.0-snapshot-20250424201746" |
oliverigor
force-pushed
the
rusty/inlining-component-types
branch
from
b64061b to
d8880e2
Compare
oliverigor
force-pushed
the
rusty/inlining-component-types
branch
from
d8880e2 to
cce89e8
Compare
18 participants
I'll port the changes from here once we're ready and bring only dts files over here