Draft
Conversation
laurelthorburn
force-pushed
the
pos-v2-docs
branch
from
b193e4a to
7e41feb
Compare
laurelthorburn
force-pushed
the
pos-v2-docs
branch
2 times, most recently
from
22bf516 to
bbfc6f0
Compare
laurelthorburn
force-pushed
the
pos-v2-docs
branch
from
cb9f57d to
8b7679e
Compare
Ensures ClickableEvents and other Events/Slots (EmptyStateSlots, ChoiceListEvents, DateFieldEvents, ModalEvents, ModalSlots, TextFieldEvents, TextFieldSlots, SearchFieldEvents, TimeFieldEvents, NumberFieldEvents, NumberFieldSlots, DatePickerEvents, DateSpinnerEvents, SectionSlots, TimePickerEvents, PageSlots, PosBlockSlots) are included in generated POS docs. Co-authored-by: Cursor <cursoragent@cursor.com>
- Add @publicdocs to Events and Slots interfaces in point-of-sale components.d.ts - Add @publicdocs to component/object interfaces (Button, Clickable, SearchField, DatePicker, Modal, etc.) so they appear as top-level keys in generated_docs_data_v2.json - Add @publicdocs to EmbedProps, TabListJSXProps; Navigation and Window in navigation-api - Ensures all 86 types referenced in 2026-01 MDX are emitted to v2 (no fallback needed) Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Closes https://github.com/Shopify/temp-project-mover-Archetypically-20260312105649/issues/388
TL;DR: We are ready to begin the migration of POS docs to the latest major gen docs release.
Solution
Doc generation: Added
/** @publicDocs */immediately before every top level interface for POS ONLY.Why this approach: The existing doc pipeline uses
@publicDocsto decide what to include; adding the tag is the minimal, consistent fix and matches how other public API surfaces are documented.yarn docs:point-of-sale 2026-01to generate the generated docs data v2 json file in the shopify-dev repoChecklist