Update known PR zip prefixes and allow zone lookup by partial zip if country hides provinces #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rochlefebvre
force-pushed
the
update-zip-prefix-handling
branch
from
9020c42 to
496b390
Compare
rochlefebvre
commented
Feb 24, 2025
| @@ -494,6 +499,13 @@ def province_optional? | |||
| province_optional || !@zones&.any?(&:province?) | |||
| end | |||
|
|
|||
| # Returns true if this country has zones defined, and has postal code prefix data for the zones | |||
| def has_zip_prefixes? | |||
There was a problem hiding this comment.
I am making this method public.
There was a problem hiding this comment.
We should add this to the changelog
rochlefebvre
commented
Feb 24, 2025
| @@ -57,6 +57,56 @@ class RegionDataConsistencyTest < ActiveSupport::TestCase | |||
| end | |||
| end | |||
|
|
|||
| test "If a country has zip_prefixes, then every province has at least one prefix" do | |||
There was a problem hiding this comment.
The two consistency suites were updated with tests that did not make it into the Worldwide gem's initial release.
gabypancu
approved these changes
Feb 24, 2025
| next if country.zones.blank? | ||
| next unless country.zones.any? { |zone| zone.neighbours.present? } | ||
|
|
||
| # Fix `neighboring_zones` data in India and Thailand |
There was a problem hiding this comment.
This is a TODO? Are we missing some neighbouring zones?
| @@ -494,6 +499,13 @@ def province_optional? | |||
| province_optional || !@zones&.any?(&:province?) | |||
| end | |||
|
|
|||
| # Returns true if this country has zones defined, and has postal code prefix data for the zones | |||
| def has_zip_prefixes? | |||
There was a problem hiding this comment.
We should add this to the changelog
rochlefebvre
force-pushed
the
update-zip-prefix-handling
branch
from
496b390 to
dce8836
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
We're updating the list of Portugal zip prefixes to be less stale. The updates in this PR are accurate as of Februrary 2023: still stale, but better.
Also, some wallet pay providers only provide the first part of an address postal code and we still need to look up info on their hidden zone metadata. We're updating
Region#zone(zip:)to accept an incomplete zip and resolve the first zone that contains this zip, as long as the country hides provinces from addresses.Checklist