Open
Conversation
Signed-off-by: Pascal Sthamer <pascal+github@sthamer.xyz>
Signed-off-by: Pascal Sthamer <pascal+github@sthamer.xyz>
P4sca1
force-pushed
the
assignment-missmatch-gofmt
branch
from
e65d22e to
ec2f7a0
Compare
Signed-off-by: Pascal Sthamer <pascal+github@sthamer.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following issue:# github.com/shuffle/shuffle-shared ai.go:432:30: assignment mismatch: 3 variables but schemaless.Translate returns 2 valuesThis issue was fixed by @0x0elliot in the meantime.
Also formats all go files using
go fmt ./..., to ensure a consistent code style and easier to review pull requests in the future (because changes do not contain a bunch of unrelated formatting changes).I recommend checking formatting in a CI pipeline to avoid unformatted code from being checked in.
@frikky Could you have a look?