feat: add cc-clip ECC bundle#99
Conversation
…cc-clip-instincts.yaml)
…plementation-tests.md)
ShunmeiCho
left a comment
There was a problem hiding this comment.
Requesting changes. This auto-generated skill bundle injects inaccurate, repo-contradicting
guidance into the agent workflow, and does so with implicit invocation enabled. I'd recommend
not merging the generated batch as-is, and instead landing a small, human-maintained repo
guidance file with implicit invocation turned off.
P1 (blocking): the generated skill injects wrong rules, implicitly
.agents/skills/cc-clip/SKILL.mdwraps its entire body in a```markdownfence
(line 1 through EOF), so the whole skill renders as one code block rather than active content.- It states the Go import style is "relative imports" with
import ("internal/daemon", "internal/tunnel"). That's wrong: the module is
github.com/shunmei/cc-clip(go.mod), and Go modules don't support relative imports.
Correct form isgithub.com/shunmei/cc-clip/internal/daemon. .agents/skills/cc-clip/agents/openai.yamlsetsallow_implicit_invocation: true, so the
above gets injected without an explicit request.- The generated instincts claim tests live in
tests/or__tests__/
(.claude/homunculus/instincts/inherited/cc-clip-instincts.yaml:121), contradicting this
repo's Go convention of colocated*_test.gofiles.
Fix: replace the auto-generated skill with minimal, hand-written repo guidance, and remove
implicit invocation.
P2: repo-local Codex config makes external MCP/npx the default run surface
.codex/config.toml pulls GitHub / Context7 / Memory / Playwright servers via npx -y and
configures a remote Exa MCP by default — turning a personal/org tool choice into the repo's
default runtime. This also contradicts the same PR's .codex/AGENTS.md, which says private
MCPs belong in ~/.codex/config.toml. Please ship these as an optional template/doc rather
than a committed default .codex/config.toml.
P3: diff hygiene
git diff --check origin/main...HEAD reports trailing-whitespace / missing-final-newline
issues in .agents/skills/cc-clip/SKILL.md, .claude/skills/cc-clip/SKILL.md, and the
.claude/homunculus/...yaml files. CI passed because it builds/vets/tests Go only and doesn't
gate docs/config.
Summary
Auto-generated ECC bundle from repository analysis.
What This Does
Merging this PR adds repo-local ECC artifacts for both Claude Code and Codex. The generated bundle captures repository patterns, Codex baseline config, and reusable workflow scaffolds derived from git history analysis.
Analysis Scope
Files
.claude/ecc-tools.json.claude/skills/cc-clip/SKILL.md.agents/skills/cc-clip/SKILL.md.agents/skills/cc-clip/agents/openai.yaml.claude/identity.json.codex/config.toml.codex/AGENTS.md.codex/agents/explorer.toml.codex/agents/reviewer.toml.codex/agents/docs-researcher.toml.claude/homunculus/instincts/inherited/cc-clip-instincts.yaml.claude/commands/feature-development-implementation-tests.md.claude/commands/documentation-update-multilingual.md.claude/commands/test-suite-expansion.mdOptional: Continuous Learning (20 instincts)
This PR also includes instincts for the continuous-learning-v2 skill. These are optional and only useful if you use that skill.
Import after merging:
Review Checklist
ECC Tools | Everything Claude Code