feat(documents): implement clinical document lifecycle invariants (CYN-40) - #38
Merged
SiddharthaGF merged 6 commits intoAug 6, 2026
Conversation
SiddharthaGF
temporarily deployed
to
pablosantiago/cyn-40-implement-clinical-document-lifecycle-invariants - cynara-api PR #38
August 6, 2026 07:39 — with
Render
Destroyed
|
Neon branch ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inProgress→completed/canceled/enteredInError, andcompleted→enteredInError; invalid transitions fail atomically without touching the bound responsePOST /api/clinicalDocuments/{id}/complete|cancel|enter-in-errorwith optimistic concurrency (rowVersion), capability gates, and audit (document.completed/document.canceled/document.enteredInError)Test plan
dotnet cake --target=Check(format + lint + tests) — 356 tests, 0 warningsdocument.completedauditcanceled, bound response stays draft; stalerowVersion→ 409; complete/cancel on a completed document → 409ClinicalDocumentLifecyclestate machine + service transition branches (concurrency, actor policy, atomicity) — 39 document unit testsLinear:
Sonar cleanup (same branch)
refactor(application): introduceIWorkflowContext(tenant + clock) to bring 4 services with S107 (8 ctor params) back to 7 —ClinicalDocumentService,EncounterService,DocumentCatalogService,FormReviewServicerefactor(api): resolve remaining smells —CapabilityForbiddenExceptionstandard constructors (S3871), expression-bodied lambda, doc comment, conditional accesstest(capabilities): add missing assertion toRequireAsync_Passes_WhenCapabilityGranted(S2699)chore(sonar): exclude generated EFMigrations/from analysis (S104 onInitialCreate+ CPD noise on generated DDL)new_violations: 0,new_duplicated_lines_density: 1.79%, 0 unresolved issues