Add transformer tap setting correction to match PSSE #1428
Merged
Conversation
Contributor
Author
|
Need to do the same for Transformer3W and develop a test system with "bad" tap settings for both |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the transformer tap setting calculation to match the PSSE specifications and adds a test to verify the correction logic.
- Updated transformer tap calculation with a nearest-step correction logic in the PSSE parser.
- Added a new test set for validating the transformer tap setting correction.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/test_parse_psse.jl | Added test set for transformer tap position correction. |
| src/parsers/pm_io/psse.jl | Updated transformer tap calculation with step correction logic. |
3WTransformer tap position correction to match PSSE
jd-lara
reviewed
Jun 27, 2025
jd-lara
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1427