Skip to content

3WTransformer tap position correction to match PSSE#1431

Merged
m-bossart merged 4 commits into
mb/transformer-tap-correctionfrom
ml/transformer-3w-correction
Jun 26, 2025
Merged

3WTransformer tap position correction to match PSSE#1431
m-bossart merged 4 commits into
mb/transformer-tap-correctionfrom
ml/transformer-3w-correction

Conversation

@mcllerena

Copy link
Copy Markdown
Contributor

No description provided.

@mcllerena mcllerena requested a review from m-bossart June 24, 2025 19:27

@m-bossart m-bossart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few questions

Comment thread src/parsers/pm_io/psse.jl
Comment thread test/test_parse_psse.jl Outdated
"case14_3wt_tap_correction";
force_build = true,
)
trf_3w = get_component(TapTransformer, sys, "BUS 109-BUS 104-BUS 107-i_1")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be getting a Transformer3W?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do the fix.

@m-bossart

Copy link
Copy Markdown
Contributor

Can we also double check by running the large system validations before and after this change.

@mcllerena mcllerena requested a review from m-bossart June 26, 2025 15:34
@m-bossart m-bossart merged commit 4a9d510 into mb/transformer-tap-correction Jun 26, 2025
1 of 9 checks passed
@jd-lara jd-lara deleted the ml/transformer-3w-correction branch August 1, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants