Fix logging for valid bustype and devices#1434
Merged
Merged
Conversation
jd-lara
reviewed
Jun 25, 2025
| if !get_available(gen) | ||
| bus_to_pv_device_map = Dict((i, Set{String}()) for i in get_number.(buses)) | ||
| for gen in get_components(StaticInjection, sys) | ||
| if !get_available(gen) || typeof(gen) == ElectricLoad |
Member
There was a problem hiding this comment.
This makes me think we need a trait for static injectors as something like supports_voltage_control because we have a similar pattern in PowerFlows.jl
jd-lara
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the logic of proper combinations of bustypes and devices:
Checks that PV and SLACK buses have either a non-electric load static injection or an hvdc connected.
Does not check PQ buses.
Fixes excessive logging in tests to to ACTIVG systems. If the underlying data for these systems is corrected, the tests can be updated.