Add synchronous condenser logic to ps_table_data#1440
Merged
Conversation
daniel-thom
reviewed
Jun 26, 2025
| rating = calculate_rating(active_power_limits, reactive_power_limits) | ||
| base_power = gen.base_mva | ||
|
|
||
| println(active_power_limits, " ", reactive_power_limits, " ", rating) |
Contributor
There was a problem hiding this comment.
Can you remove the debug print?
| return reactive_power, reactive_power_limits | ||
| end | ||
|
|
||
| function make_synchronous_condenser( |
Contributor
There was a problem hiding this comment.
Is this the same function name as in the PSSE parser? Do we have some way of disambiguating the function calls? I'm wondering if we need a prefix on each of these "make" functions. I also see that this may be an existing problem.
Contributor
Author
There was a problem hiding this comment.
I have changed the name for this one, didn't realize the others have different naming as well.
daniel-thom
approved these changes
Jun 26, 2025
jd-lara
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.