fix(docs): Update OpenTelemetry Collector binary docs#2545
fix(docs): Update OpenTelemetry Collector binary docs#2545crazyuploader wants to merge 6 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@claude /review |
|
Claude finished @crazyuploader's task in 2m 43s —— View job Code Review Complete ✓
Review SummaryThis PR consolidates and updates OpenTelemetry Collector binary documentation. I've reviewed all 6 changed files against the CONTRIBUTING.md checklist. The changes are generally well-structured, but I've identified several issues that need attention. Critical Issues1. NGINX Documentation - Malformed Code BlocksFile: The "Compile Locally" bash code blocks (appears in 3 places) have multiple commands run together without proper line breaks. This makes them impossible to copy-paste correctly. See inline comment for the fix. Lines affected: 31-41, 103-113, 224-235 2. Missing Frontmatter FieldsFile: The doc is missing the doc_type: tutorialNote: It's already present in the current version, so this is good! ✓ 3. Technical Accuracy Check NeededFile: The OTLP endpoint format needs verification. According to OpenTelemetry nginx module docs, when using OTLP/HTTP, the endpoint should be the base collector endpoint without Current: Verify if this should be: Otherwise, requests may go to Good Practices Observed ✓
Minor Issues1. Inconsistent Configuration Between DocsFile: The shared component removed the Deleted from shared component: service:
telemetry:
metrics:
address: 0.0.0.0:8888This section exposed Collector's internal metrics on port 8888. If removed intentionally, ensure users know how to monitor the Collector itself. 2. Prometheus Receiver Target Commented OutFile: scrape_configs:
- job_name: otel-collector-binary
static_configs:
- targets:
# - localhost:8888 # Replace the target endpoint with a Prometheus exporterThe comment says "Replace the target endpoint" but doesn't explain what to replace it with or when. Consider adding guidance like: # - localhost:8888 # Uncomment to scrape Collector's own metrics
# - localhost:9090 # Add your application's Prometheus metrics endpoint here3. Windows Limitation Not DocumentedFile: The config includes <Admonition type="warning">
Windows users: Remove the `processes` scraper from the hostmetrics receiver as it's not supported on Windows.
</Admonition>Checklist Against CONTRIBUTING.md
Add to Onboarding LabelNot required. This PR modifies existing documentation rather than adding new integration/collection methods. The label Recommendations
Technical Verification Sources
|
|
Claude finished @crazyuploader's task in 3m 43s —— View job Code Review Complete ✓
Review SummaryThis PR consolidates and updates OpenTelemetry Collector binary documentation. I've reviewed all 6 changed files against the CONTRIBUTING.md guidelines. The changes are well-structured and most previous review issues have been addressed. What Changed
Previous Review Status✅ FIXED: The NGINX bash code blocks are now properly formatted with each command on its own line (lines 40-49, 103-113, 224-235) ✅ VERIFIED: NGINX OTLP endpoint format is correct - ✅ DOCUMENTED: The Issues Found (See Inline Comments)I've posted 4 inline comments for specific issues:
Checklist Against CONTRIBUTING.md
Technical VerificationAll configurations have been verified against official OpenTelemetry documentation:
Add to Onboarding LabelNot required. This PR modifies/renames existing documentation rather than adding a NEW doc that explains how to send data to SigNoz Cloud. The label is only needed when brand new integration/collection docs are added. Recommendations
Overall AssessmentThe PR is in good shape. The documentation updates are accurate, well-structured, and follow the guidelines. The technical configurations have been verified against official OpenTelemetry sources. The main items are minor improvements suggested in the inline comments. | Branch: fix/otel-collector-config |
Closes: #3695
Doc: Link