feat(docs): Add Deno instrumentation doc#2598
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@claude /review |
|
Claude finished @crazyuploader's task in 3m 29s —— View job Review SummaryThis PR adds comprehensive Deno instrumentation documentation. The structure follows the Send Data docs template well, covering multiple deployment types (VM, Kubernetes, Docker, Windows) and both auto-instrumentation and code-level instrumentation approaches. Issues FoundI've provided inline comments for the following issues that need to be addressed:
What's Correct
Label Added✅ Added |
|
📚 Onboarding issue created… see #2599 |
|
Claude finished @crazyuploader's task in 2m 11s —— View job Review CompleteI've thoroughly reviewed this Deno instrumentation documentation PR against the CONTRIBUTING.md guidelines and verified technical accuracy against official Deno sources. SummaryThis PR adds comprehensive Deno instrumentation documentation following the Send Data docs template. The structure is solid, covering all deployment types and instrumentation approaches. However, there's one critical correction needed regarding a previous review comment, plus the documentation would benefit from the missing sections already identified. Previous Review Comment CorrectionThe inline comment about This is technically accurate according to the official Deno documentation. The previous review incorrectly claimed the doc said Issues Still Requiring AttentionThe documentation is missing two required sections per CONTRIBUTING.md:
What's CorrectVerified against CONTRIBUTING.md checklist:
Required Changes1. Fix Collector section (line 307) Add the missing required links as specified in CONTRIBUTING.md. Change: See [Switch from direct export to Collector](https://signoz.io/docs/opentelemetry-collection-agents/opentelemetry-collector/switch-to-collector/) for step-by-step instructions.To: See [Switch from direct export to Collector](https://signoz.io/docs/opentelemetry-collection-agents/opentelemetry-collector/switch-to-collector/) for step-by-step instructions.
For more details, see [Why use the OpenTelemetry Collector?](https://signoz.io/docs/opentelemetry-collection-agents/opentelemetry-collector/why-to-use-collector/) and the [Collector configuration guide](https://signoz.io/docs/opentelemetry-collection-agents/opentelemetry-collector/configuration/).Label Status✅ Added SourcesTechnical accuracy verified against: |
makeavish
left a comment
There was a problem hiding this comment.
Deno supports logs, metrics, traces all with otel but I don't it being mentioned clearly
makeavish
left a comment
There was a problem hiding this comment.
- Not added to logs and metrics listicle page as discussed
- It should not be Send Traces to SigNoz:

- Code level instrumentation tab is essentially manual span creation which is very different. It should be separate optional step like - https://signoz-web-git-chore-add-deno-instrumentation-doc-signoz.vercel.app/docs/instrumentation/manual-instrumentation/ruby/manual-instrumentation/
Closes: #1283
Doc: Link