chore: correct order within page result

[srikanthccv]

Summary

Part of #5373

---

Important

Add sorting functionality to various list responses in the inframetrics package, allowing records to be sorted based on specified OrderBy criteria.

• Behavior:
  • Adds SortBy method to ClusterListResponse, DaemonSetListResponse, DeploymentListResponse, JobListResponse, NamespaceListResponse, NodeListResponse, PodListResponse, StatefulSetListResponse, and VolumeListResponse in infra.go.
  • Sorts records based on OrderBy criteria, defaulting to descending order.
  • Reverses order if OrderBy.Order is v3.DirectionAsc.
• Functions:
  • Calls SortBy in GetClusterList() in clusters.go, GetDaemonSetList() in daemonsets.go, GetDeploymentList() in deployments.go, GetJobList() in jobs.go, GetNamespaceList() in namespaces.go, GetNodeList() in nodes.go, GetPodList() in pods.go, GetPvcList() in pvcs.go, and GetStatefulSetList() in statefulsets.go.

^{This description was created by for b07aa18. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to b07aa18 in 1 minute and 21 seconds

More details

• Looked at 539 lines of code in 10 files
• Skipped 0 files when reviewing.
• Skipped posting 9 drafted comments based on config settings.

1. pkg/query-service/app/inframetrics/clusters.go:341

• Draft comment:
  Check if req.OrderBy is nil before calling SortBy to avoid potential nil pointer dereference.
• Reason this comment was not posted:
  Comment looked like it was already resolved.

2. pkg/query-service/app/inframetrics/daemonsets.go:443

• Draft comment:
  Check if req.OrderBy is nil before calling SortBy to avoid potential nil pointer dereference.
• Reason this comment was not posted:
  Marked as duplicate.

3. pkg/query-service/app/inframetrics/deployments.go:443

• Draft comment:
  Check if req.OrderBy is nil before calling SortBy to avoid potential nil pointer dereference.
• Reason this comment was not posted:
  Marked as duplicate.

4. pkg/query-service/app/inframetrics/jobs.go:497

• Draft comment:
  Check if req.OrderBy is nil before calling SortBy to avoid potential nil pointer dereference.
• Reason this comment was not posted:
  Marked as duplicate.

5. pkg/query-service/app/inframetrics/namespaces.go:344

• Draft comment:
  Check if req.OrderBy is nil before calling SortBy to avoid potential nil pointer dereference.
• Reason this comment was not posted:
  Marked as duplicate.

6. pkg/query-service/app/inframetrics/nodes.go:357

• Draft comment:
  Check if req.OrderBy is nil before calling SortBy to avoid potential nil pointer dereference.
• Reason this comment was not posted:
  Marked as duplicate.

7. pkg/query-service/app/inframetrics/pods.go:407

• Draft comment:
  Check if req.OrderBy is nil before calling SortBy to avoid potential nil pointer dereference.
• Reason this comment was not posted:
  Marked as duplicate.

8. pkg/query-service/app/inframetrics/pvcs.go:377

• Draft comment:
  Check if req.OrderBy is nil before calling SortBy to avoid potential nil pointer dereference.
• Reason this comment was not posted:
  Marked as duplicate.

9. pkg/query-service/model/infra.go:117

• Draft comment:
  Avoid adding non-ClickHouse related functions to the ClickHouseReader interface. The SortBy method is correctly placed in the model package.
• Reason this comment was not posted:
  Comment looked like it was already resolved.

Workflow ID: wflow_KSzGVudvxgEeBxrB

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.