Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the issue of logs preview and count mismatch in pipelines by updating sample logs query param from limit to pageSize #7231

Merged
merged 3 commits into from
Mar 6, 2025

Conversation

ahmadshaheer
Copy link
Collaborator

@ahmadshaheer ahmadshaheer commented Mar 6, 2025

Summary

Related Issues / PR's

close https://github.com/SigNoz/engineering-pod/issues/2200

Screenshots

NA

Affected Areas and Manually Tested Areas


Important

Fixes logs preview and count mismatch by changing query parameter from limit to pageSize in useSampleLogs.

  • Behavior:
    • Fixes logs preview and count mismatch by changing query parameter from limit to pageSize in useSampleLogs.
  • Files:
    • useSampleLogs.ts: Updates query parameter in useMemo hook.

This description was created by Ellipsis for 566ddbc. It will automatically update as commits are pushed.

@ahmadshaheer ahmadshaheer requested a review from YounixM as a code owner March 6, 2025 05:34
@github-actions github-actions bot added the bug Something isn't working label Mar 6, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 566ddbc in 48 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. frontend/src/container/PipelinePage/PipelineListsView/Preview/hooks/useSampleLogs.ts:41
  • Draft comment:
    Changing from 'limit' to 'pageSize' aligns with updated API expectations for pagination. Make sure the backend also expects 'pageSize'.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is asking the PR author to ensure that the backend is updated to expect pageSize instead of limit. This falls under asking the author to double-check or ensure behavior, which is against the rules.
2. frontend/src/container/PipelinePage/PipelineListsView/Preview/hooks/useSampleLogs.ts:41
  • Draft comment:
    Using 'count || DEFAULT_SAMPLE_LOGS_COUNT' may unintentionally override a count of 0. Consider explicitly checking for undefined (e.g., count !== undefined ? count : DEFAULT_SAMPLE_LOGS_COUNT) if a zero value is valid.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_tTV6IGbZtNV7WU4v


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Member

@nityanandagohain nityanandagohain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working as expected.

@ahmadshaheer ahmadshaheer enabled auto-merge (squash) March 6, 2025 14:47
@ahmadshaheer ahmadshaheer merged commit 29fa5c3 into main Mar 6, 2025
14 of 16 checks passed
@ahmadshaheer ahmadshaheer deleted the fix/pipeline-preview-and-count-mismatch branch March 6, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants