Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing send_resolved for email/pager/opsgenie edit payload #7240

Merged
merged 2 commits into from
Mar 8, 2025

Conversation

srikanthccv
Copy link
Member

@srikanthccv srikanthccv commented Mar 7, 2025

Summary

Fixes #7233

Fixes #7131

The send_resolved prop is not sent in the edit request payload for email/pagerduty/opsgenie alert channels.


Important

Adds send_resolved to email, pagerduty, and opsgenie edit payloads in index.tsx.

  • Behavior:
    • Adds send_resolved property to the payload in prepareEmailRequest, preparePagerRequest, and prepareOpsgenieRequest in index.tsx.
    • Ensures send_resolved is sent with edit requests for email, pagerduty, and opsgenie channels.

This description was created by Ellipsis for 00f9ba1. It will automatically update as commits are pushed.

@srikanthccv srikanthccv requested a review from amlannandy March 7, 2025 16:09
@srikanthccv srikanthccv requested a review from YounixM as a code owner March 7, 2025 16:09
@github-actions github-actions bot added the bug Something isn't working label Mar 7, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 00f9ba1 in 2 minutes and 42 seconds

More details
  • Looked at 28 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 6 drafted comments based on config settings.
1. frontend/src/container/EditAlertChannels/index.tsx:175
  • Draft comment:
    Good: send_resolved is now included in the email request payload. This will correctly send a false value if disabled.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
2. frontend/src/container/EditAlertChannels/index.tsx:211
  • Draft comment:
    Good: send_resolved is now correctly included in the pager request payload.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
3. frontend/src/container/EditAlertChannels/index.tsx:265
  • Draft comment:
    Good: send_resolved is added in the Opsgenie request payload, resolving the bug for edit mode.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
4. frontend/src/container/EditAlertChannels/index.tsx:175
  • Draft comment:
    Good: send_resolved is now added to the email payload to fix Disabling send_resolved doesn't work in edit mode #7233.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is purely informative, stating what has been done in the code without providing any actionable feedback or suggestions. It does not align with the rules for useful comments.
5. frontend/src/container/EditAlertChannels/index.tsx:210
  • Draft comment:
    Good: send_resolved is added to the pager payload; this ensures the edited config reflects the proper state.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is purely informative and does not provide any actionable feedback or suggestions for improvement. It simply acknowledges a change without offering any constructive input.
6. frontend/src/container/EditAlertChannels/index.tsx:263
  • Draft comment:
    Good: send_resolved is now included in the Opsgenie payload to properly handle resolved notifications in edit mode.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is purely informative, explaining a change made in the code without suggesting any action or asking for clarification. It doesn't align with the rules for useful comments.

Workflow ID: wflow_XCky6Mm9gbf3KO4M


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@srikanthccv srikanthccv merged commit 8abba26 into main Mar 8, 2025
14 of 16 checks passed
@srikanthccv srikanthccv deleted the fix-7233 branch March 8, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants