Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bundle FE for the OSS #7306

Closed
wants to merge 1 commit into from
Closed

fix: bundle FE for the OSS #7306

wants to merge 1 commit into from

Conversation

prashant-shahi
Copy link
Member

@prashant-shahi prashant-shahi commented Mar 13, 2025

Summary

  • bundle FE for the OSS

Related Issues / PR's

NA

Screenshots

NA

Affected Areas and Manually Tested Areas

NA


Important

Add step in Dockerfile to copy frontend build to /etc/signoz/web/.

  • Dockerfile Changes:
    • Add step to copy frontend build from frontend/build/ to /etc/signoz/web/ in Dockerfile.

This description was created by Ellipsis for 9fea850. It will automatically update as commits are pushed.

Signed-off-by: Prashant Shahi <[email protected]>
@github-actions github-actions bot added the bug Something isn't working label Mar 13, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 9fea850 in 1 minute and 29 seconds

More details
  • Looked at 14 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. pkg/query-service/Dockerfile:27
  • Draft comment:
    Consider explicitly creating the destination directory (/etc/signoz/web) with a RUN mkdir -p command before copying, to ensure the directory exists and has the expected permissions.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50%
    Docker COPY command automatically creates destination directories if they don't exist. While explicit directory creation can help with permissions, the default permissions are usually sufficient. The comment doesn't point out any specific permission requirements or issues. The suggestion is more of a style preference than a necessary change.
    The comment could be valid if there are specific permission requirements for the web directory that aren't being met by default COPY behavior.
    Without evidence of specific permission requirements or issues, this appears to be an unnecessary suggestion since COPY handles directory creation automatically.
    Delete the comment as it suggests an unnecessary step - Docker's COPY command already handles directory creation, and there's no evidence of specific permission requirements.
2. pkg/query-service/Dockerfile:26
  • Draft comment:
    Ensure the frontend assets directory (/etc/signoz/web/) has correct permissions and is correctly utilized by query-service. Consider explicitly creating and permissioning this directory if needed.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None

Workflow ID: wflow_Hm9hfev8ct9WxSEm


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@grandwizard28
Copy link
Collaborator

Closing this in favour of a PR raised by the community #7247

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants