Prepend necessary conditions to query #53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As tackled in #52 and #51, this PR is a proposal for fixing errors encountered in regex oring and in correlations rules.
For details see these issues.
Description
To summarize, we have two problems:
|re
in a correlation rule, the field targeted will disappear in the result query)| eval
parts, and then handle the logic using a final| search
. However, splunk need to get something at the beginning of the query (just before the first|
)Proposal
So, I implemented a way to detect necessary conditions (understand conditions which doesn't have an OR in their parents), and as AND operator is commutative, deferred them and add them at the start of the query in the
finalize_query
process.This will :
Caution
This PR need pysigma to reactivate the
finalize_query
for rules that are part of correlation rules, as described in #52.