-
Notifications
You must be signed in to change notification settings - Fork 13
ci: build for windows arm64 #1084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+150
−2,479
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
a31e57f
ci: add Windows ARM64 build to GitHub Actions matrix
clementb49 997b978
fix(ci): fix ARM64 Windows build for cryptography dependency
clementb49 13a6f7a
fix(ci): install ARM64 OpenSSL via vcpkg to build cryptography
clementb49 3ee5b2f
feat: restrict accessible_output3 to x86/x86_64 Windows
clementb49 ce6a2d6
fix(ci): fix invalid arm64compatible in Inno Setup script
clementb49 ef20163
ci: use actions/checkout to fetch vcpkg instead of git clone
clementb49 112292e
fix(updater): detect ARM64 architecture for update download
clementb49 8a79cc3
fix: remove uv environment restriction
clementb49 dbbe0e1
fix: correct vcpkg build path
clementb49 4c4af59
feat: use vcpkg action
clementb49 119ab5a
fix: add missing github token
clementb49 5c0e009
fix: change vcpkg subdir
clementb49 7cb3c2d
fix: move repository checkout
clementb49 6dc9929
fix: use a a subdir for repo checkout
clementb49 638606e
fix: correct path for installer
clementb49 8cc1fb4
fix: correct path for windows installer spec
clementb49 574ea22
fix: change GITHUB_WORKSPACE env var
clementb49 7da9f31
fix: sppecify innosetup script as relative path
clementb49 901ed26
fix: use the correct sub path to upload setup
clementb49 a3ef151
fix: remove archive for pot file
clementb49 e2616d5
feat: disable workflow when only .pre-commit config file is updated
clementb49 a9e8df7
fix: prevent crash in handle when accessible_output3 is unavailable
clementb49 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion | 🟠 Major
🧩 Analysis chain
🏁 Script executed:
Repository: SigmaNight/basiliskLLM
Length of output: 703
🏁 Script executed:
Repository: SigmaNight/basiliskLLM
Length of output: 4350
🏁 Script executed:
Repository: SigmaNight/basiliskLLM
Length of output: 348
🏁 Script executed:
Repository: SigmaNight/basiliskLLM
Length of output: 610
Fix type annotation for
accessible_outputproperty; it can returnNoneor_NullAccessibleOutput, not justAuto.The
accessible_outputproperty is typed asaccessible_output3.outputs.auto.Auto(line 106), but can actually returnNone(whenuse_accessible_outputis False; see line 99) or_NullAccessibleOutput(line 92). Both_NullAccessibleOutputandAutoprovidespeak()andbraille()methods, which are the only methods actually called (lines 150, 158).Use a
Protocolto properly express this contract:Proposed typing refactor
🤖 Prompt for AI Agents