Skip to content

fix(ci): setup MSVC for x86 to fix dependency builds#1261

Merged
AAClause merged 1 commit into
masterfrom
fix/ci-x86-build-msvc
Jul 11, 2026
Merged

fix(ci): setup MSVC for x86 to fix dependency builds#1261
AAClause merged 1 commit into
masterfrom
fix/ci-x86-build-msvc

Conversation

@AAClause

@AAClause AAClause commented Jul 11, 2026

Copy link
Copy Markdown
Member
  • fix(ci): pin cryptography>=46,<49 and relax dep ranges to fix x86 build failures
  • fix(ci): setup MSVC for x86 to fix dependency builds

Summary by CodeRabbit

  • Bug Fixes
    • Improved Windows x86 build reliability by setting up the 32-bit compiler environment before installing dependencies.
    • Kept build behavior unchanged for other supported architectures.
  • Dependency Updates
    • Updated Python dependencies, including cryptography and openai, to newer version ranges.
  • Packaging
    • Expanded package inclusion for frozen builds by adding backports to the bundled archive contents.

@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@AAClause, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 4 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: e329d67c-6ea3-494a-a3bc-2f3dfcfbc010

📥 Commits

Reviewing files that changed from the base of the PR and between 365f5b2 and 0c5fcc0.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml

Walkthrough

The Windows workflow now configures MSVC for x86 builds. Project packaging adds cryptography, updates the openai version range, and includes backports in frozen packages.

Changes

Build and packaging configuration

Layer / File(s) Summary
Conditional x86 MSVC setup
.github/workflows/build_app.yml
Adds an x86-only MSVC development environment step before dependency installation.
Dependency and frozen-package configuration
pyproject.toml
Adds cryptography, updates the openai constraint, and includes backports in the cx_Freeze zip package list.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly reflects the main CI fix for x86 MSVC setup and dependency builds.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ci-x86-build-msvc

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/build_app.yml:
- Around line 47-51: Pin the ilammy/msvc-dev-cmd action used by the “Setup MSVC
for x86” step to the commit hash currently referenced by v1, replacing the
mutable tag while preserving the existing x86 architecture configuration.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: fe7130b6-ea62-46f5-98ea-08043de92529

📥 Commits

Reviewing files that changed from the base of the PR and between 2b8fbfa and 2c89220.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • .github/workflows/build_app.yml
  • pyproject.toml

Comment thread .github/workflows/build_app.yml Outdated
@AAClause AAClause changed the title fix/ci x86 build msvc fix(ci): add MSVC setup for x86 and pin cryptography to fix 32-bit builds Jul 11, 2026
@AAClause
AAClause force-pushed the fix/ci-x86-build-msvc branch from 10c26c3 to 31dc281 Compare July 11, 2026 20:23
@AAClause AAClause changed the title fix(ci): add MSVC setup for x86 and pin cryptography to fix 32-bit builds fix(ci): setup MSVC for x86 to fix dependency builds Jul 11, 2026
@AAClause
AAClause force-pushed the fix/ci-x86-build-msvc branch 6 times, most recently from 7e1c4ee to a995e7d Compare July 11, 2026 20:49
@AAClause AAClause closed this Jul 11, 2026
@AAClause
AAClause force-pushed the fix/ci-x86-build-msvc branch from 0fd8b22 to 2b8fbfa Compare July 11, 2026 20:54
@AAClause AAClause reopened this Jul 11, 2026
@AAClause
AAClause force-pushed the fix/ci-x86-build-msvc branch from 45e5441 to 26d3fa5 Compare July 11, 2026 21:02
@AAClause AAClause closed this Jul 11, 2026
@AAClause
AAClause force-pushed the fix/ci-x86-build-msvc branch from 26d3fa5 to 2b8fbfa Compare July 11, 2026 21:05
@AAClause AAClause reopened this Jul 11, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/build_app.yml:
- Around line 90-97: In the MSVC reactivation block guarded by VCVARSALL,
immediately check the errorlevel after call "%VCVARSALL%" amd64_x86 and fail the
step with a clear error message when it is nonzero. Keep the existing compiler
verification commands for successful reactivation.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: a8138ccd-1e4c-4222-ad2e-3c97954a0e7a

📥 Commits

Reviewing files that changed from the base of the PR and between 2c89220 and 39ccd25.

📒 Files selected for processing (1)
  • .github/workflows/build_app.yml

Comment thread .github/workflows/build_app.yml Outdated
@AAClause
AAClause force-pushed the fix/ci-x86-build-msvc branch 2 times, most recently from 56fa98e to 4eefc2e Compare July 11, 2026 21:53
Comment thread .github/workflows/build_app.yml Fixed
Comment thread .github/workflows/build_app.yml Fixed
Comment thread .github/workflows/build_app.yml Fixed
@AAClause
AAClause force-pushed the fix/ci-x86-build-msvc branch from c0096ce to 365f5b2 Compare July 11, 2026 22:18

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@pyproject.toml`:
- Line 160: Remove “backports” from the zip_include_packages list in the
cx_Freeze configuration, leaving the other package entries unchanged. Only
retain it if the project explicitly installs a corresponding backports
distribution.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 0457ddfc-6604-4045-80e8-3a3f2ba39742

📥 Commits

Reviewing files that changed from the base of the PR and between 39ccd25 and 365f5b2.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • .github/workflows/build_app.yml
  • pyproject.toml

Comment thread pyproject.toml Outdated
@AAClause
AAClause force-pushed the fix/ci-x86-build-msvc branch 2 times, most recently from cc5ad99 to 4ac4e23 Compare July 11, 2026 22:44
The x86 (32-bit) job was failing at 'Install dependencies' because
cryptography>=49 (and some other packages) lack cp314-win32 wheels for
Python 3.14.

- Pin cryptography>=46.0.0,<49 directly in pyproject.toml
@AAClause
AAClause force-pushed the fix/ci-x86-build-msvc branch from 4ac4e23 to 0c5fcc0 Compare July 11, 2026 23:13
@AAClause
AAClause merged commit 30360ba into master Jul 11, 2026
13 checks passed
@AAClause
AAClause deleted the fix/ci-x86-build-msvc branch July 11, 2026 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants