fix(ci): setup MSVC for x86 to fix dependency builds#1261
Conversation
|
Warning Review limit reached
Next review available in: 4 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
WalkthroughThe Windows workflow now configures MSVC for x86 builds. Project packaging adds ChangesBuild and packaging configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/build_app.yml:
- Around line 47-51: Pin the ilammy/msvc-dev-cmd action used by the “Setup MSVC
for x86” step to the commit hash currently referenced by v1, replacing the
mutable tag while preserving the existing x86 architecture configuration.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: fe7130b6-ea62-46f5-98ea-08043de92529
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
.github/workflows/build_app.ymlpyproject.toml
10c26c3 to
31dc281
Compare
7e1c4ee to
a995e7d
Compare
0fd8b22 to
2b8fbfa
Compare
45e5441 to
26d3fa5
Compare
26d3fa5 to
2b8fbfa
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/build_app.yml:
- Around line 90-97: In the MSVC reactivation block guarded by VCVARSALL,
immediately check the errorlevel after call "%VCVARSALL%" amd64_x86 and fail the
step with a clear error message when it is nonzero. Keep the existing compiler
verification commands for successful reactivation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: a8138ccd-1e4c-4222-ad2e-3c97954a0e7a
📒 Files selected for processing (1)
.github/workflows/build_app.yml
56fa98e to
4eefc2e
Compare
c0096ce to
365f5b2
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pyproject.toml`:
- Line 160: Remove “backports” from the zip_include_packages list in the
cx_Freeze configuration, leaving the other package entries unchanged. Only
retain it if the project explicitly installs a corresponding backports
distribution.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 0457ddfc-6604-4045-80e8-3a3f2ba39742
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
.github/workflows/build_app.ymlpyproject.toml
cc5ad99 to
4ac4e23
Compare
The x86 (32-bit) job was failing at 'Install dependencies' because cryptography>=49 (and some other packages) lack cp314-win32 wheels for Python 3.14. - Pin cryptography>=46.0.0,<49 directly in pyproject.toml
4ac4e23 to
0c5fcc0
Compare
Summary by CodeRabbit
cryptographyandopenai, to newer version ranges.backportsto the bundled archive contents.