refactor: dynamic hook loading replaced by hardcoded list#128
Closed
sarfata wants to merge 3 commits intoSignalK:masterfrom
Closed
refactor: dynamic hook loading replaced by hardcoded list#128sarfata wants to merge 3 commits intoSignalK:masterfrom
sarfata wants to merge 3 commits intoSignalK:masterfrom
Conversation
sarfata
force-pushed
the
refactor/hardcode-list-of-hooks
branch
from
7cdac44 to
9cb5a88
Compare
sarfata
changed the title
APB always return an error. Add a test so we can confirm that error-behaviour does not change while doing some refactoring later.
The use of promises inside the parser-nmea0183 library forces caller into an asynchronous mode but we do not actually need Promises here since all the data can be parsed/calculated immediately. This change should be completely backwards compatible for callers. They will still receive a Promise and it will resolve/reject as it did before. However, doing this refactor will make it much easier to introduce a new, non-promise based API soon.
Loading the list of hooks from the filesystem at runtime was very fancy but it does not work well when the project is webpacked and used in a browser.
sarfata
force-pushed
the
refactor/hardcode-list-of-hooks
branch
from
9cb5a88 to
fa576cc
Compare
Contributor
Author
|
included in #130 - closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR, to merge after #127 (which it is based on) removes hardcoded list of hooks so the project can be used with webpack.