Skip to content

feature: make the plugin configuration a table of available plugins#2152

Merged
sbender9 merged 15 commits intomasterfrom
plugin-config-list
Dec 4, 2025
Merged

feature: make the plugin configuration a table of available plugins#2152
sbender9 merged 15 commits intomasterfrom
plugin-config-list

Conversation

@sbender9
Copy link
Member

@sbender9 sbender9 commented Dec 2, 2025

image

Mobile:

MacBook

@sbender9 sbender9 changed the title feature: make the plugin configuration a table of available plugin feature: make the plugin configuration a table of available plugins Dec 2, 2025
@sbender9 sbender9 requested a review from tkurki December 2, 2025 15:20
@JohnySeven
Copy link

Great! It makes plugin configuration less messy! Search is good. I would place plugin status status at second place, as it's more important than package name or description.

Maybe put plugin name and description into one column and put plugin name at first line and description behind?

Maybe adding option to filter out disabled/not configured/enabled plugins might be option for enhancement.

@sbender9
Copy link
Member Author

sbender9 commented Dec 2, 2025

Great! It makes plugin configuration less messy! Search is good. I would place plugin status status at second place, as it's more important than package name or description.

Maybe put plugin name and description into one column and put plugin name at first line and description behind?

Maybe adding option to filter out disabled/not configured/enabled plugins might be option for enhancement.

I added the filter by status, I kinda like the way the list looks now, so I'll wait to see what other's say about that.

@JohnStov
Copy link

JohnStov commented Dec 2, 2025

I think I agree with @JohnySeven - put the status column in second place and package name in 3rd, probably with description as sub item in that column. I don't think I'd ever want to sort or select by description

@dirkwa
Copy link
Contributor

dirkwa commented Dec 2, 2025

Is there also a view for mobile devices? With current I am even not able to see the button to reach the npmjs page to read what it does.

@sbender9
Copy link
Member Author

sbender9 commented Dec 2, 2025

Is there also a view for mobile devices? With current I am even not able to see the button to reach the npmjs page to read what it does.

I think you're talking about the AppStore? There's no npm button in Plugin Configuration.

@tkurki
Copy link
Member

tkurki commented Dec 2, 2025

I agree that plugin's name and status are the most important things and should be kept together. Is the pluginpackage name any use for the end user? Description is, especially for the plugins installed by default.

I think there should be something that hints that you need to click a row to do stuff, either a [Configure] or a cogwheel button.

[Config Required] is too obnoxious, as it will show for the default plugins that you don't have configured but can't remove.

Can we make [Submit] read [Save configuration]?

#2136 needs to be merged first - have you looked at it? Maybe rebase this on that, test two things at the same time?

@tkurki
Copy link
Member

tkurki commented Dec 2, 2025

Fyi I also started with this a while ago but did not get far, let's continue along your route

image

master...plugin-configuration-tabs

@sbender9
Copy link
Member Author

sbender9 commented Dec 2, 2025

[Config Required] is too obnoxious, as it will show for the default plugins that you don't have configured but can't remove.

So you think just show "Disabled" for those?

@sbender9
Copy link
Member Author

sbender9 commented Dec 2, 2025

I think there should be something that hints that you need to click a row to do stuff, either a [Configure] or a cogwheel button.

how's this?

image

@sbender9 sbender9 force-pushed the plugin-config-list branch 3 times, most recently from 26394b7 to 0c9f7db Compare December 2, 2025 18:44
@sbender9
Copy link
Member Author

sbender9 commented Dec 2, 2025

@tkurki does this look right? Tried to rebase on #2136

@tkurki
Copy link
Member

tkurki commented Dec 2, 2025

Much nicer! Config required still blares and is way longer than the others though.

Would cogwheel and status badge work in a combined, single column?

@sbender9 sbender9 merged commit 591dc6b into master Dec 4, 2025
5 checks passed
@sbender9 sbender9 deleted the plugin-config-list branch December 4, 2025 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants