feat: enable source priority filtering at boot time#2193
Open
KEGustafsson wants to merge 2 commits intoSignalK:masterfrom
Open
feat: enable source priority filtering at boot time#2193KEGustafsson wants to merge 2 commits intoSignalK:masterfrom
KEGustafsson wants to merge 2 commits intoSignalK:masterfrom
Conversation
Delays acceptance of lower-priority sources at startup until cumulative timeouts of higher-priority sources have elapsed, giving preferred sources time to connect before fallbacks are accepted.
Contributor
Author
|
Failing tests are not due to this change. |
Member
|
Working on the unrelated failure... |
Member
|
Could we just initialise |
Initialize paths as if the highest precedence source produced data at boot time, allowing the existing timeout logic to handle filtering. This replaces the separate filterStartTime tracking and cumulative timeout calculation.
Contributor
|
Sorry Karl-Erik, Superseded by #2379 when merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add time to sources at boot time to enable source priority filtering work correctly.
Current implementation allowing all sources to enter the Signal K before source priority starts to filter sources.